Ted-Jiang commented on code in PR #2671:
URL: https://github.com/apache/arrow-datafusion/pull/2671#discussion_r888051780
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -344,6 +362,10 @@ fn fetch_statistics(
table_idx,
stats,
)
+ } else {
+ // If none statistics of current column exists, set
the Max/Min Accumulator to None.
Review Comment:
> > If i miss something, plz tell me
>
> Once max_values and min_values are set to none, even if the column
statistics exists in next row_group, summarize_min_max will do nothing because
the max_values and min_values are none.
Ohh, thanks i will check later.
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -344,6 +362,10 @@ fn fetch_statistics(
table_idx,
stats,
)
+ } else {
+ // If none statistics of current column exists, set
the Max/Min Accumulator to None.
Review Comment:
> > If i miss something, plz tell me
>
> Once max_values and min_values are set to none, even if the column
statistics exists in next row_group, summarize_min_max will do nothing because
the max_values and min_values are none.
Ohh, thanks i will check later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
