HaoYang670 commented on issue #1750: URL: https://github.com/apache/arrow-rs/issues/1750#issuecomment-1144471150
>The suggestion is never to push offsets down within ArrayData Although we don't push down the offset within `ArrayData::slice` (Based on your 1st suggestion `Remove the ArrayData::slice special-case`), we do push it down within `StructArray::from` (Based on your 2nd suggestion `Slice child data within StructArray when constructing boxed_fields`) because we must slice on each `child_data` to construct the correct child array. As a result, I guess your suggestions (slicing child arrays within `StructArray::from()`) and the current implementation (slicing the child data within `ArrayData::slice()`) are equivalent. I am not 100% sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
