pitrou commented on a change in pull request #8143:
URL: https://github.com/apache/arrow/pull/8143#discussion_r485888089
##########
File path: cpp/src/arrow/util/decimal.cc
##########
@@ -42,34 +45,40 @@ namespace arrow {
using internal::SafeLeftShift;
using internal::SafeSignedAdd;
+#ifdef __SIZEOF_INT128__
+using uint128_t = __uint128_t;
+#else
+using boost::multiprecision::uint128_t;
+#endif
Review comment:
Hmm, surely we can avoid using `operator<<`? We can just note the
limitations in the header file. It would be internal anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
