pitrou commented on a change in pull request #8143: URL: https://github.com/apache/arrow/pull/8143#discussion_r486307010
########## File path: cpp/src/arrow/util/int128_internal.h ########## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +#pragma once + +#ifndef __SIZEOF_INT128__ +#include <boost/multiprecision/cpp_int.hpp> +#endif + +namespace arrow { +namespace internal { + +// NOTE: __int128_t and boost::multiprecision::int128_t are not interchangeable. +// For example, __int128_t does not have any member function, and does not have +// operator<<(std::ostream, __int128_t). On the other hand, the behavior of +// boost::multiprecision::int128_t might be surprising with some configs (e.g., +// static_cast<uint64_t>(boost::multiprecision::uint128_t) might return +// ~uint64_t{0} instead of the lower 64 bits of the input). Review comment: Fun :-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
