rok commented on PR #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1149746730
> @rok I'm not sure how to take a decision based on these graphs. We care about monotonicity in UTC timestamps, right? The graph don't seem to show a particular problem in that case. The graphs are to supplement testing as we can cover bigger parameter space and see if results make sense. The `preserve_wall` option preserves monotonicity in wall time as well by flattening part of ambiguous periods. I suppose we only need monotonicity in UTC so `preserve_wall` can be removed and introduced if asked for. What would you be in favour of? > TBH, I'm starting to question the entire idea of rounding in local time. What are the use cases? Use case would be something like when do users form a certain country come to my website. Rounding in UTC would be inconsistent. I believe it is a needed feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
