emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r892882125
##########
python/pyarrow/_gcsfs.pyx:
##########
@@ -151,17 +159,17 @@ cdef class GcsFileSystem(FileSystem):
def _reconstruct(cls, kwargs):
return cls(**kwargs)
- def _expiration_datetime_from_options(self):
+ def _expiration_ns_from_options(self):
expiration_ns = TimePoint_to_ns(
self.gcsfs.options().credentials.expiration())
if expiration_ns == 0:
return None
- return datetime.fromtimestamp(expiration_ns / 1e9)
Review Comment:
@pitrou this is where I think we end up losing precision. When I looked at
the delta from logs in C++ (see prior commits), I might have been doing the
math wrong, but I think it was about a 6 hour delta (not just a microseconds vs
nanoseconds issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
