emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r892883315
##########
python/pyarrow/_gcsfs.pyx:
##########
@@ -151,17 +159,17 @@ cdef class GcsFileSystem(FileSystem):
def _reconstruct(cls, kwargs):
return cls(**kwargs)
- def _expiration_datetime_from_options(self):
+ def _expiration_ns_from_options(self):
expiration_ns = TimePoint_to_ns(
self.gcsfs.options().credentials.expiration())
if expiration_ns == 0:
return None
- return datetime.fromtimestamp(expiration_ns / 1e9)
Review Comment:
CC @rok
https://github.com/apache/arrow/pull/12763/commits/a071da99a6a7c29ac01271f816ad53d157840416
is the commit. I don't think this is just microsecond vs nanosecond (the
delta looked bigger to me but it was a little bit late). Note that this
previous formulation worked for me locally and in CI. The error appeared to
crop up only on a specific Mac/Python combo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
