tustvold commented on code in PR #1822:
URL: https://github.com/apache/arrow-rs/pull/1822#discussion_r892889013
##########
.github/workflows/rust.yml:
##########
@@ -108,31 +108,42 @@ jobs:
# run tests on all workspace members with default feature list
cargo test
-
- # Switch to arrow crate
- cd arrow
- # re-run tests on arrow crate to ensure
- # all arrays are created correctly
- cargo test --features=force_validate
- cargo test --features=prettyprint
- # run test on arrow crate with minimal set of features
- cargo test --no-default-features
+
+ # re-run tests on arrow crate with all supported features
+ cargo test -p arrow --features=force_validate,prettyprint
+
+ # Test arrow examples
cargo run --example builders
cargo run --example dynamic_types
cargo run --example read_csv
cargo run --example read_csv_infer_schema
- cargo check --no-default-features
+
+ # Test compilation of arrow library crate with different feature
combinations
+ cargo check -p arrow
+ cargo check -p arrow --no-default-features
+
+ # Test compilation of arrow targets with different feature
combinations
Review Comment:
It would theoretically be more correct to test each target individually, so
that feature resolution is not impacted by other targets, in practice this is
probably good enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
