alamb commented on code in PR #1822:
URL: https://github.com/apache/arrow-rs/pull/1822#discussion_r893530014
##########
.github/workflows/rust.yml:
##########
@@ -108,31 +108,39 @@ jobs:
# run tests on all workspace members with default feature list
cargo test
-
- # Switch to arrow crate
- cd arrow
- # re-run tests on arrow crate to ensure
- # all arrays are created correctly
- cargo test --features=force_validate
- cargo test --features=prettyprint
- # run test on arrow crate with minimal set of features
- cargo test --no-default-features
+
+ # re-run tests on arrow crate with all supported features
+ cargo test -p arrow --features=force_validate,prettyprint
Review Comment:
I think the original rationale was to try and test without the default
features (mostly I think to try and catch build errors, which this PR does in
another way)
##########
.github/workflows/rust.yml:
##########
@@ -108,31 +108,39 @@ jobs:
# run tests on all workspace members with default feature list
cargo test
-
- # Switch to arrow crate
- cd arrow
- # re-run tests on arrow crate to ensure
- # all arrays are created correctly
- cargo test --features=force_validate
- cargo test --features=prettyprint
- # run test on arrow crate with minimal set of features
- cargo test --no-default-features
+
+ # re-run tests on arrow crate with all supported features
+ cargo test -p arrow --features=force_validate,prettyprint
+
+ # Test arrow examples
cargo run --example builders
cargo run --example dynamic_types
cargo run --example read_csv
cargo run --example read_csv_infer_schema
- cargo check --no-default-features
+
Review Comment:
Maybe it would be worth making a separate named run step (as is done
https://github.com/apache/arrow-rs/pull/1822/files#diff-73e17259d77e5fbef83b2bdbbe4dc40a912f807472287f7f45b77e0cbf78792dR188)
> - name: Check compilation with simd features
So when/if this check fails it will be easier to figure out what is wrong
##########
Cargo.toml:
##########
@@ -24,6 +24,7 @@ members = [
"arrow-flight",
"integration-testing",
]
+resolver = "2"
Review Comment:
Can you please add a comment / doc link explaining what this does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
