nl5887 commented on code in PR #1839:
URL: https://github.com/apache/arrow-rs/pull/1839#discussion_r894771359
##########
arrow/src/datatypes/datatype.rs:
##########
@@ -684,10 +684,17 @@ impl DataType {
&& a.data_type().equals_datatype(b.data_type())
}
(DataType::Struct(a), DataType::Struct(b)) => {
- a.len() == b.len()
- && a.iter().zip(b).all(|(a, b)| {
- a.is_nullable() == b.is_nullable()
- && a.data_type().equals_datatype(b.data_type())
+ a.iter().all(|a| {
Review Comment:
Agreed, I've added a method compatible_datatype, and reverted my changes to
equal_datatype.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
