nl5887 commented on code in PR #1839:
URL: https://github.com/apache/arrow-rs/pull/1839#discussion_r894776550
##########
arrow/src/compute/kernels/concat.rs:
##########
@@ -62,7 +62,7 @@ pub fn concat(arrays: &[&dyn Array]) -> Result<ArrayRef> {
if arrays
.iter()
- .any(|array| array.data_type() != arrays[0].data_type())
+ .any(|array| !array.data_type().equals_datatype(arrays[0].data_type()))
Review Comment:
I think this should be changed to compatible_datatype (at least for my own
usecase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
