thamht4190 commented on a change in pull request #8023: URL: https://github.com/apache/arrow/pull/8023#discussion_r486420973
########## File path: cpp/src/parquet/key_toolkit.h ########## @@ -0,0 +1,123 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <memory> +#include <string> +#include <vector> + +#include "parquet/key_encryption_key.h" +#include "parquet/kms_client.h" +#include "parquet/kms_client_factory.h" +#include "parquet/platform.h" +#include "parquet/two_level_cache_with_expiration.h" + +namespace parquet { +namespace encryption { + +class KeyWithMasterID { + public: + KeyWithMasterID(const std::string& key_bytes, const std::string& master_id) + : key_bytes_(key_bytes), master_id_(master_id) {} + + const std::string& data_key() const { return key_bytes_; } + const std::string& master_id() const { return master_id_; } + + private: + std::string key_bytes_; + std::string master_id_; +}; + +class PARQUET_EXPORT KeyToolkit { + public: + class KmsClientCache { + public: + static KmsClientCache& GetInstance() { + static KmsClientCache instance; + return instance; + } + TwoLevelCacheWithExpiration<std::shared_ptr<KmsClient>>& cache() { return cache_; } + + private: + TwoLevelCacheWithExpiration<std::shared_ptr<KmsClient>> cache_; + }; + + class KEKWriteCache { + public: + static KEKWriteCache& GetInstance() { + static KEKWriteCache instance; + return instance; + } + TwoLevelCacheWithExpiration<KeyEncryptionKey>& cache() { return cache_; } + + private: + TwoLevelCacheWithExpiration<KeyEncryptionKey> cache_; + }; + + class KEKReadCache { + public: + static KEKReadCache& GetInstance() { + static KEKReadCache instance; + return instance; + } + TwoLevelCacheWithExpiration<std::string>& cache() { return cache_; } + + private: + TwoLevelCacheWithExpiration<std::string> cache_; + }; + + // KMS client two level cache: token -> KMSInstanceId -> KmsClient + static TwoLevelCacheWithExpiration<std::shared_ptr<KmsClient>>& + kms_client_cache_per_token() { + return KmsClientCache::GetInstance().cache(); + } + + // KEK two level cache for wrapping: token -> MEK_ID -> KeyEncryptionKey + static TwoLevelCacheWithExpiration<KeyEncryptionKey>& kek_write_cache_per_token() { + return KEKWriteCache::GetInstance().cache(); + } + + // KEK two level cache for unwrapping: token -> KEK_ID -> KEK bytes + static TwoLevelCacheWithExpiration<std::string>& kek_read_cache_per_token() { + return KEKReadCache::GetInstance().cache(); + } + + static std::shared_ptr<KmsClient> GetKmsClient( + std::shared_ptr<KmsClientFactory> kms_client_factory, Review comment: > Why isn't this a method on KmsClientFactory? @pitrou because here we get from the cache, we create a new client from factory only if the item is not in the cache (or the corresponding token expires). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
