pitrou commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r896670389
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -252,6 +254,192 @@ struct ARROW_EXPORT ExecBatch {
inline bool operator==(const ExecBatch& l, const ExecBatch& r) { return
l.Equals(r); }
inline bool operator!=(const ExecBatch& l, const ExecBatch& r) { return
!l.Equals(r); }
+struct ExecValue {
+ enum Kind { ARRAY, SCALAR };
+ Kind kind = ARRAY;
+ ArraySpan array;
+ const Scalar* scalar;
Review Comment:
If you want to micro-optimize this structure, you could have `scalar ==
nullptr` mean it's an array :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
