pitrou commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r896661638


##########
cpp/src/arrow/type.h:
##########
@@ -174,6 +175,25 @@ class ARROW_EXPORT DataType : public 
detail::Fingerprintable {
   /// \brief Return the type category of the storage type
   virtual Type::type storage_id() const { return id_; }
 
+  /// \brief Returns the type's fixed byte width, if any. Returns -1
+  /// for non-fixed-width types, and should only be used for
+  /// subclasses of FixedWidthType
+  virtual int32_t byte_width() const {

Review Comment:
   This method doesn't need to be virtual, does it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to