wesm commented on code in PR #13364:
URL: https://github.com/apache/arrow/pull/13364#discussion_r897399042
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -20,6 +20,8 @@
#pragma once
+#include <algorithm>
Review Comment:
noted, will fix
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -252,6 +254,192 @@ struct ARROW_EXPORT ExecBatch {
inline bool operator==(const ExecBatch& l, const ExecBatch& r) { return
l.Equals(r); }
inline bool operator!=(const ExecBatch& l, const ExecBatch& r) { return
!l.Equals(r); }
+struct ExecValue {
+ enum Kind { ARRAY, SCALAR };
+ Kind kind = ARRAY;
+ ArraySpan array;
+ const Scalar* scalar;
Review Comment:
Good idea, I'll do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
