wesm commented on PR #13364: URL: https://github.com/apache/arrow/pull/13364#issuecomment-1155805661
Thanks for the reviews -- I'll make sure that these things get taken care of. Several items: * What's the latest and greatest way to see a full comparison table of microbenchmarks? I wouldn't expect this PR to have too much immediate impact * Regarding the `Copy` methods -- I have read through some of Scott Meyers https://www.oreilly.com/library/view/effective-modern-c/9781491908419/ch04.html and I can't find any evidence that adding `std::enable_shared_from_this` necessarily makes things any slower or adds overhead to instantiations. What do you think about just calling this `GetSharedPtr` and letting the `std::enable_shared_from_this` slide? The alternative is that we add `Copy` implementations that actually copy, and add a virtual `ExtensionType::CopyImpl` that must be implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
