zeroshade commented on code in PR #13381:
URL: https://github.com/apache/arrow/pull/13381#discussion_r898153389
##########
go/arrow/array/concat_test.go:
##########
@@ -289,13 +288,3 @@ func (cts *ConcatTestSuite) TestCheckConcat() {
})
}
}
-
-func TestOffsetOverflow(t *testing.T) {
- fakeOffsets :=
memory.NewBufferBytes(arrow.Int32Traits.CastToBytes([]int32{0, math.MaxInt32}))
- fakeArr := array.NewStringData(array.NewData(arrow.BinaryTypes.String,
1, []*memory.Buffer{nil, fakeOffsets, memory.NewBufferBytes([]byte{})}, nil, 0,
0))
- var err error
- assert.NotPanics(t, func() {
- _, err = array.Concatenate([]arrow.Array{fakeArr, fakeArr},
memory.DefaultAllocator)
- })
- assert.EqualError(t, err, "offset overflow while concatenating arrays")
-}
Review Comment:
Since you added the recover to the concatenate function, it might make sense
to leave this test so that we are testing the recover is working correctly and
returning the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
