zeroshade commented on code in PR #13381:
URL: https://github.com/apache/arrow/pull/13381#discussion_r898323553
##########
go/arrow/ipc/reader.go:
##########
@@ -54,7 +54,12 @@ type Reader struct {
// NewReaderFromMessageReader allows constructing a new reader object with the
// provided MessageReader allowing injection of reading messages other than
// by simple streaming bytes such as Arrow Flight which receives a protobuf
message
-func NewReaderFromMessageReader(r MessageReader, opts ...Option) (*Reader,
error) {
+func NewReaderFromMessageReader(r MessageReader, opts ...Option) (reader
*Reader, err error) {
+ defer func() {
+ if pErr := recover(); pErr != nil {
+ err = fmt.Errorf("arrow/ipc: unknown error while
reading: %v", pErr)
+ }
+ }()
Review Comment:
can we add a test for this? same for the writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
