lidavidm commented on code in PR #13390:
URL: https://github.com/apache/arrow/pull/13390#discussion_r900280168
##########
cpp/src/arrow/engine/substrait/relation_internal.cc:
##########
@@ -106,25 +106,37 @@ Result<compute::Declaration> FromProto(const
substrait::Rel& rel,
path = item.uri_path_glob();
}
+ ::arrow::internal::Uri uri;
+ RETURN_NOT_OK(uri.Parse(path));
if (item.format() ==
substrait::ReadRel::LocalFiles::FileOrFiles::FILE_FORMAT_PARQUET) {
format = std::make_shared<dataset::ParquetFileFormat>();
- } else if (util::string_view{path}.ends_with(".arrow")) {
+ } else if (uri.extension() == ".arrow") {
Review Comment:
I suggested it mostly for completeness, I don't think it's particularly
likely though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
