rtpsw commented on code in PR #13375:
URL: https://github.com/apache/arrow/pull/13375#discussion_r901078427
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -229,6 +229,20 @@ class ARROW_EXPORT SinkNodeConsumer {
virtual Future<> Finish() = 0;
};
+class ARROW_EXPORT NullSinkNodeConsumer : public SinkNodeConsumer {
+ public:
+ Status Init(const std::shared_ptr<Schema>&, BackpressureControl*) override {
+ return Status::OK();
+ }
+ Status Consume(ExecBatch exec_batch) override { return Status::OK(); }
+ Future<> Finish() override { return Status::OK(); }
+
+ public:
+ static std::shared_ptr<NullSinkNodeConsumer> Make() {
+ return std::make_shared<NullSinkNodeConsumer>();
+ }
Review Comment:
This allows for convenient passing of `NullSinkNodeConsumer::Make` as an
argument. But you're right I didn't use it yet - in `DeserializePlans` of
`cpp/src/arrow/engine/substrait/util.cc` - I'll fix it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
