rtpsw commented on code in PR #13375:
URL: https://github.com/apache/arrow/pull/13375#discussion_r901100424
##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -95,6 +96,17 @@ class ARROW_ENGINE_EXPORT ExtensionIdRegistry {
virtual Status CanRegisterFunction(Id,
const std::string& arrow_function_name)
const = 0;
virtual Status RegisterFunction(Id, std::string arrow_function_name) = 0;
+
+ /// \brief Add a symbol external to the plan yet used in an Id.
+ ///
+ /// This ensures the symbol, which is only viewed but not held by the Id,
lives while
+ /// the extension set does. Symbols appearing in the Substrait plan are
already held.
+ const std::string& AddExternalSymbol(const std::string& symbol) {
+ return *external_symbols.insert(symbol).first;
+ }
Review Comment:
I'll fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
