waynexia commented on code in PR #2721:
URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r901118189
##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -1254,32 +1373,31 @@ async fn join_with_hash_unsupported_data_type() ->
Result<()> {
);
let expected = vec![
- "+----+-----+-----+------------+----+-----+-----+------------+",
- "| c1 | c2 | c3 | c4 | c1 | c2 | c3 | c4 |",
- "+----+-----+-----+------------+----+-----+-----+------------+",
- "| 1 | aaa | 100 | 1970-01-02 | 1 | aaa | 100 | 1970-01-02 |",
- "| 2 | bbb | 200 | 1970-01-03 | 2 | bbb | 200 | 1970-01-03 |",
- "| 3 | ccc | 300 | 1970-01-04 | 3 | ccc | 300 | 1970-01-04 |",
- "+----+-----+-----+------------+----+-----+-----+------------+",
+
"+------------+------------+---------+-----+------------+------------+------------+-----------+---------+------------+",
+ "| c1 | c2 | c3 | c4 | c5 | c1 |
c2 | c3 | c4 | c5 |",
+
"+------------+------------+---------+-----+------------+------------+------------+-----------+---------+------------+",
+ "| | | | | | |
| 100000.00 | abcdefg | |",
+ "| | | | | | |
1970-01-04 | 0.00 | qwerty | 74776f |",
+ "| | 1970-01-04 | 789.00 | ghi | | 1970-01-04 |
| 789.00 | | 7468726565 |",
+ "| 1970-01-04 | | -123.12 | jkl | 7468726565 | 1970-01-02 |
1970-01-02 | -123.12 | abc | 6f6e65 |",
+
"+------------+------------+---------+-----+------------+------------+------------+-----------+---------+------------+",
];
let results = execute_to_batches(&ctx, sql).await;
assert_batches_sorted_eq!(expected, &results);
Review Comment:
I agree. That wrong c5 is not actually a correct row in t1.
>and we then file ticket to chase down the real problem.
@AssHero cannot reproduce this might also be a clue. And I hope we can add
c5 back in the next fixing PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
