liukun4515 commented on code in PR #2721:
URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r902241633
##########
datafusion/core/src/physical_plan/hash_join.rs:
##########
@@ -1054,6 +1110,116 @@ fn equal_rows(
DataType::LargeUtf8 => {
equal_rows_elem!(LargeStringArray, l, r, left, right,
null_equals_null)
}
+ DataType::Decimal(_, lscale) => match r.data_type() {
+ DataType::Decimal(_, rscale) => {
+ if lscale == rscale {
+ equal_rows_elem!(
+ DecimalArray,
+ l,
+ r,
+ left,
+ right,
+ null_equals_null
+ )
+ } else {
Review Comment:
If the coerced type has been calculated, we don't need to check the data
type between left and right.
Do you think so? @alamb @waynexia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
