nealrichardson commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r901794827
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2794,18 +2795,17 @@ macro(resolve_dependency_absl)
endforeach()
# Extracted the dependency information using the Abseil pkg-config files:
- # grep Requires $PREFIX/pkgconfig/absl_*.pc | \
+ # grep Requires $PREFIX/lib/pkgconfig/absl_*.pc | \
# sed -e 's;.*/absl_;set_property(TARGET absl::;' \
# -e 's/.pc:Requires:/ PROPERTY INTERFACE_LINK_LIBRARIES /' \
- # -e 's/ = 20210324,//g' \
- # -e 's/ = 20210324//g' \
+ # -E -e 's/ = 20[0-9]{6},?//g' \
Review Comment:
I simplified this regex so that it is robust to future abseil version bumps
(at least until 2030!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
