nealrichardson commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r901798660
##########
r/src/filesystem.cpp:
##########
@@ -33,6 +33,12 @@ const char* r6_class_name<fs::FileSystem>::get(
return "LocalFileSystem";
} else if (type_name == "s3") {
return "S3FileSystem";
+ } else if (type_name == "gcs") {
+ return "GcsFileSystem";
+ } else if (type_name == "abfs") {
+ return "AzureBlobFileSystem";
+ } else if (type_name == "hdfs") {
+ return "HadoopFileSystem";
Review Comment:
Put them here for completeness but we should probably comment this block out
for now since these R6 classes don't exist yet and the default fallback to
FileSystem might allow things to Just Work if you're linking to a C++ library
that has support for these built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
