avantgardnerio opened a new pull request, #2797:
URL: https://github.com/apache/arrow-datafusion/pull/2797

   # Which issue does this PR close?
   
   Closes #2796.
   
    # Rationale for this change
   In order to pass TPC-H benchmarks, datafusion will need to be able to 
support month & year date intervals.
   
   # What changes are included in this PR?
   
   A refactoring of the datetime module to:
   1. Support `IntervalYearMonth` in addition to the currently supported 
`IntervalDayTime`
   2. Perform some non-trivial date modulo math (that I hopefully got correct)
   3. Add tests to ensure modulo math edge cases work correctly
   4. Switch to an arguably more readable [railroad error handling 
pattern](https://fsharpforfunandprofit.com/rop/) to take better advantage of 
the error propagation (`?`) operator.
   
   # Are there any user-facing changes?
   More queries should work. Nothing that worked previously should break.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to