avantgardnerio commented on code in PR #2797:
URL: https://github.com/apache/arrow-datafusion/pull/2797#discussion_r910183035
##########
datafusion/common/src/scalar.rs:
##########
@@ -87,11 +89,14 @@ pub enum ScalarValue {
TimestampMicrosecond(Option<i64>, Option<String>),
/// Timestamp Nanoseconds
TimestampNanosecond(Option<i64>, Option<String>),
- /// Interval with YearMonth unit
+ /// Number of elapsed whole months
IntervalYearMonth(Option<i32>),
- /// Interval with DayTime unit
+ /// Number of elapsed days and milliseconds (no leap seconds)
+ /// stored as 2 contiguous 32-bit signed integers
IntervalDayTime(Option<i64>),
- /// Interval with MonthDayNano unit
+ /// A triple of the number of elapsed months, days, and nanoseconds.
+ /// Months and days are encoded as 32-bit signed integers.
+ /// Nanoseconds is encoded as a 64-bit signed integer (no leap seconds).
Review Comment:
The docs are unfortunately ambiguous as to what order these words are stored
in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
