dragosmg commented on code in PR #13440:
URL: https://github.com/apache/arrow/pull/13440#discussion_r909521107
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -533,6 +533,15 @@ test_that("extract yday from timestamp", {
)
})
+test_that("extract qday from timestamp", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(datetime)) %>%
+ collect(),
+ test_df
+ )
+})
Review Comment:
```suggestion
compare_dplyr_binding(
.input %>%
mutate(x = qday(as.POSIXct("2022-06-29 12:35))) %>%
collect(),
test_df
)
})
```
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -719,6 +728,22 @@ test_that("extract yday from date", {
)
})
+test_that("extract qday from date", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(date)) %>%
+ collect(),
+ test_df
+ )
+
+ compare_dplyr_binding(
+ .input %>%
+ mutate(y = qday(as.Date(date))) %>%
Review Comment:
```suggestion
mutate(y = qday(as.Date("2022-06-29"))) %>%
```
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -719,6 +728,15 @@ test_that("extract yday from date", {
)
})
+test_that("extract qday from date", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(date)) %>%
+ collect(),
+ test_df
+ )
+})
+
Review Comment:
I added 2 suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
