avantgardnerio commented on code in PR #2797:
URL: https://github.com/apache/arrow-datafusion/pull/2797#discussion_r910186338
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -1951,7 +1951,7 @@ mod tests {
let date_plus_interval_expr = to_timestamp_expr(ts_string)
.cast_to(&DataType::Date32, schema)
.unwrap()
- + Expr::Literal(ScalarValue::IntervalDayTime(Some(123)));
Review Comment:
Based upon tests that used the parser to load "real" dates seemed to confirm
the lower-order bytes are the `ms` part, so this was adding `123ms` which
wasn't enough to bump the 32 bit date forward. Since the parser based tests are
more likely to be correct than this hand-rolled one, I updated this to match
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
