thisisnic commented on code in PR #13070:
URL: https://github.com/apache/arrow/pull/13070#discussion_r912907161
##########
r/R/dplyr-datetime-helpers.R:
##########
@@ -105,7 +105,12 @@ binding_as_date <- function(x,
tryFormats = "%Y-%m-%d",
origin = "1970-01-01") {
if (is.null(format) && length(tryFormats) > 1) {
- abort("`as.Date()` with multiple `tryFormats` is not supported in Arrow")
+ abort(
+ paste(
+ "`as.Date()` with multiple `tryFormats` is not supported in Arrow,",
+ "consider using the specialised parsing functions"
Review Comment:
Also, sorry if this sounds super-pendntic, but clarity in error messages is
important; "in lubridate" implies that we're directing them to do it outside of
Arrow rather than being possible within an Arrow context. Something like
"consider using the lubridate specialised parsing functions such as `ymd()`,
`ydm()`, etc" might reduce this ambuguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
