thisisnic commented on code in PR #13070:
URL: https://github.com/apache/arrow/pull/13070#discussion_r912998931
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -1549,35 +1552,65 @@ test_that("`as.Date()` and `as_date()`", {
)
# we do not support multiple tryFormats
- compare_dplyr_binding(
- .input %>%
- mutate(date_char_ymd = as.Date(character_ymd_var,
- tryFormats = c("%Y-%m-%d", "%Y/%m/%d")
- )) %>%
+ # this is not a simple warning, therefore we cannot use
compare_dplyr_binding()
+ # with `warning = TRUE`
+ # arrow_table test
+ expect_warning(
+ test_df %>%
+ arrow_table() %>%
+ mutate(
+ date_char_ymd = as.Date(
+ character_ymd_var,
+ tryFormats = c("%Y-%m-%d", "%Y/%m/%d")
+ ),
+ .keep = "used"
+ ) %>%
collect(),
- test_df,
- warning = TRUE
+ regexp = "consider using the lubridate specialised parsing functions"
)
- # strptime does not support a partial format - testing an error surfaced from
- # C++ (hence not testing the content of the error message)
- # TODO revisit once - https://issues.apache.org/jira/browse/ARROW-15813
- expect_error(
+ # record batch test
+ expect_warning(
test_df %>%
- arrow_table() %>%
- mutate(date_char_ymd = as_date(character_ymd_var)) %>%
- collect()
+ record_batch() %>%
+ mutate(
+ date_char_ymd = as.Date(
+ character_ymd_var,
+ tryFormats = c("%Y-%m-%d", "%Y/%m/%d")
+ ),
+ .keep = "used"
+ ) %>%
+ collect(),
+ regexp = "consider using the lubridate specialised parsing functions"
)
+ # strptime does not support a partial format - Arrow returns NA, while
+ # lubridate parses correctly
+ # TODO revisit once - https://issues.apache.org/jira/browse/ARROW-15813
expect_error(
- test_df %>%
- arrow_table() %>%
- mutate(date_char_ymd = as.Date(character_ymd_var)) %>%
- collect(),
- regexp = "Failed to parse string: '2022-02-25 00:00:01' as a scalar of
type timestamp[s]",
- fixed = TRUE
+ expect_equal(
+ test_df %>%
+ arrow_table() %>%
+ mutate(date_char_ymd_hms = as_date(character_ymd_hms_var), .keep =
"used") %>%
Review Comment:
Out of interest, why `.keep` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
