dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r914923372
##########
r/R/dplyr-funcs.R:
##########
@@ -58,13 +58,20 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
- namespace <- gsub("::.*$", "", fun_name)
+ if (fun_name == "::") {
Review Comment:
`name` here is `"fun"` and `fun_name` is `"pkg::fun"`. In this context
isn't, technically, `fun_name` the namespace qualified one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
