dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r914927871
##########
r/R/arrow-datum.R:
##########
@@ -103,10 +103,10 @@ Ops.ArrowDatum <- function(e1, e2) {
#' @export
Math.ArrowDatum <- function(x, ..., base = exp(1), digits = 0) {
switch(.Generic,
- abs = ,
- sign = ,
- floor = ,
- ceiling = ,
+ abs = eval_array_expression("abs_checked", x),
+ sign = eval_array_expression("sign", x),
+ floor = eval_array_expression("floor", x),
+ ceiling = eval_array_expression("ceil", x),
Review Comment:
There are function in the `.unary_function_map` we definitely want to be
able to use the prefixed version for, such as `lubridate::year()` or
`stringr::str_length()`. The prefixed version might not entirely be necessary
for the {base} functions, e.g. `base::abs()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
