paleolimbot commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r916164829
##########
r/R/arrow-datum.R:
##########
@@ -103,10 +103,10 @@ Ops.ArrowDatum <- function(e1, e2) {
#' @export
Math.ArrowDatum <- function(x, ..., base = exp(1), digits = 0) {
switch(.Generic,
- abs = ,
- sign = ,
- floor = ,
- ceiling = ,
+ abs = eval_array_expression("abs_checked", x),
+ sign = eval_array_expression("sign", x),
+ floor = eval_array_expression("floor", x),
+ ceiling = eval_array_expression("ceil", x),
Review Comment:
I understand how we need to register the functions with their
namespaces...you're right that keeping the `.unary_function_map` functions
namespaced is the way to go. I think what tripped me up is that `abs()` is the
only one here that needs special handling (the others, to my reading, can just
fall through). I'll leave a code suggestion with what I mean here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
