paleolimbot commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r916169234
##########
r/tests/testthat/test-dplyr-funcs-conditional.R:
##########
@@ -29,7 +29,7 @@ test_that("if_else and ifelse", {
compare_dplyr_binding(
.input %>%
mutate(
- y = if_else(int > 5, 1, 0)
+ y = dplyr::if_else(int > 5, 1, 0)
Review Comment:
Could you remove all of the `pkg::` prefixes that are not part of a
dedicated test?
##########
r/tests/testthat/test-dataset-dplyr.R:
##########
@@ -119,7 +119,7 @@ test_that("filter() on date32 columns", {
# Also with timestamp scalar
expect_equal(
open_dataset(tmp) %>%
- filter(date > lubridate::ymd_hms("2020-02-02 00:00:00")) %>%
+ filter(date > lubridate::ymd_hms("2020-02-02 00:00:00", tz = "UTC")) %>%
Review Comment:
Is this change related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
