paleolimbot commented on code in PR #13397:
URL: https://github.com/apache/arrow/pull/13397#discussion_r916760398
##########
r/src/compute-exec.cpp:
##########
@@ -196,8 +226,13 @@ void ExecPlan_Write(
ds::WriteNodeOptions{std::move(opts), std::move(kv)});
StopIfNotOk(plan->Validate());
- StopIfNotOk(plan->StartProducing());
- StopIfNotOk(plan->finished().status());
+ auto result = RunWithCapturedRIfPossible<bool>([&]() -> arrow::Result<bool> {
+ RETURN_NOT_OK(plan->StartProducing());
+ RETURN_NOT_OK(plan->finished().status());
+ return true;
Review Comment:
I updated this - `bool` here was a dummy type because you can't do
`arrow::Result<void>` (but my use of it here was confusing so I added a helper
`RunWithCapturedRVoid()` to make it more clear what's going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
