avantgardnerio commented on code in PR #2797: URL: https://github.com/apache/arrow-datafusion/pull/2797#discussion_r917139040
########## datafusion/physical-expr/Cargo.toml: ########## @@ -44,6 +44,7 @@ arrow = { version = "17.0.0", features = ["prettyprint"] } blake2 = { version = "^0.10.2", optional = true } blake3 = { version = "1.0", optional = true } chrono = { version = "0.4", default-features = false } +chronoutil = "0.2.3" Review Comment: I inlined it in my latest push. If we want to go back to including it in cargo.toml, it's an easy revert. My $0.02 would be to leave it in cargo.toml, so that we can get updates if the author fixes something, and so that RAT checkers can see declaratively that we depend on that code, rather than trying to use heuristics of sematic code or binary diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org