vibhatha commented on code in PR #13567:
URL: https://github.com/apache/arrow/pull/13567#discussion_r918148748
##########
cpp/src/arrow/dataset/partition.cc:
##########
@@ -82,6 +82,8 @@ std::shared_ptr<Partitioning> Partitioning::Default() {
std::string type_name() const override { return "default"; }
+ bool Equals(const Partitioning& other) const override { return false; }
Review Comment:
I am not sure if I misunderstood the review comment when changing the
earlier code into this. I thought this must be always `false`. cc @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
