westonpace commented on code in PR #13567:
URL: https://github.com/apache/arrow/pull/13567#discussion_r918162355
##########
cpp/src/arrow/dataset/partition.cc:
##########
@@ -82,6 +82,8 @@ std::shared_ptr<Partitioning> Partitioning::Default() {
std::string type_name() const override { return "default"; }
+ bool Equals(const Partitioning& other) const override { return false; }
Review Comment:
I was thinking to always return false for `FunctionPartitioning`. The
default partitioning can simply return `type_name() == other.type_name()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
