alamb commented on code in PR #2875:
URL: https://github.com/apache/arrow-datafusion/pull/2875#discussion_r918244473
##########
datafusion/physical-expr/src/expressions/try_cast.rs:
##########
@@ -184,10 +198,13 @@ mod tests {
// 3. evaluate the expression
// 4. verify that the resulting expression is of type B
// 5. verify that the resulting values are downcastable and correct
+ //
+ // $VALUE_FN is an expression (like `result.value`) that extracts the
value at index `i`
macro_rules! generic_test_cast {
- ($A_ARRAY:ident, $A_TYPE:expr, $A_VEC:expr, $TYPEARRAY:ident,
$TYPE:expr, $VEC:expr) => {{
+ ($A_ARRAY:ident, $A_TYPE:expr, $A_VEC:expr, $TYPEARRAY:ident,
$TYPE:expr, $VEC:expr, $VALUE_FN:expr) => {{
Review Comment:
needed to add a way to extract the value of the result at element `i`
because it is different for a `DictionaryArray`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
