[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2875: Fix casts of `ScalarValue::Utf8` to `DictionaryArray`

Tue, 12 Jul 2022 09:40:17 -0700 


tustvold commented on code in PR #2875:
URL: https://github.com/apache/arrow-datafusion/pull/2875#discussion_r919188599


##########
datafusion/physical-expr/src/expressions/try_cast.rs:
##########
@@ -82,6 +82,19 @@ impl PhysicalExpr for TryCastExpr {
                 &array,
                 &self.cast_type,
             )?)),
+            ColumnarValue::Scalar(scalar)

Review Comment:
   Won't this prevent this from using the scalar comparison kernels, 
effectively reversing #2808 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to