vibhatha commented on code in PR #13528:
URL: https://github.com/apache/arrow/pull/13528#discussion_r918461211
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,8 +30,17 @@
namespace arrow {
namespace engine {
+/// Information resulting from converting a Substrait relation.
+struct DeclarationInfo {
+ /// The compute declaration produced thus far.
+ compute::Declaration declaration;
+
+ /// The number of columns returned by the declaration.
+ size_t num_columns;
Review Comment:
For my curiosity:
I understand your point. I am not an expert on the exact usage, although I
assumed the current customs were adopted based on a certain logic. But for
better understanding I looked into CUDF which require to expose a similar
attribute as follows.
https://github.com/pytorch/pytorch/blob/5f8c2076dfd834b21cfafe2f35d19c3d02a958dc/caffe2/core/tensor.h#L386
Here they use size_type (I guess that is the same as size_t).
PS: Numpy and PyTorch both represents the dimension in `int` or `int64_t`
but I guess it can be negative according to some definitions (I am not entirely
clear on the possibility).
cc @pitrou @wesm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
