michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919430595
##########
cpp/src/arrow/compute/exec/hash_join_node.cc:
##########
@@ -708,8 +736,26 @@ class HashJoinNode : public ExecNode {
// Generate output schema
std::shared_ptr<Schema> output_schema = schema_mgr->MakeOutputSchema(
join_options.output_suffix_for_left,
join_options.output_suffix_for_right);
+
// Create hash join implementation object
- ARROW_ASSIGN_OR_RAISE(std::unique_ptr<HashJoinImpl> impl,
HashJoinImpl::MakeBasic());
+ // SwissJoin does not support:
+ // a) 64-bit string offsets
+ // b) residual predicates
+ // c) dictionaries
+ //
+ bool use_swiss_join;
+#if ARROW_LITTLE_ENDIAN
+ use_swiss_join = (filter == literal(true)) &&
!schema_mgr->HasDictionaries() &&
+ !schema_mgr->HasLargeBinary();
+#else
+ use_swiss_join = false;
+#endif
+ std::unique_ptr<HashJoinImpl> impl;
+ if (use_swiss_join) {
+ ARROW_ASSIGN_OR_RAISE(impl, HashJoinImpl::MakeSwiss());
+ } else {
+ ARROW_ASSIGN_OR_RAISE(impl, HashJoinImpl::MakeBasic());
+ }
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
