michalursa commented on code in PR #13493:
URL: https://github.com/apache/arrow/pull/13493#discussion_r919465384
##########
cpp/src/arrow/compute/exec/hash_join_benchmark.cc:
##########
@@ -132,7 +134,7 @@ class JoinBenchmark {
left_keys, *r_batches_with_schema.schema,
right_keys,
filter, "l_", "r_"));
- join_ = *HashJoinImpl::MakeBasic();
Review Comment:
I added a parameter to BenchmarkSettings, but I don't run both variants. It
would be taking twice as much time and it would probably break graph producing
script that @save-buffer wrote for post-processing hash join benchmark results,
that may expect a single set of outputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
