dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r921936356
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -201,6 +212,14 @@ test_that("strftime", {
times
)
+ # with namespacing
Review Comment:
I went towards testing the namespaced version of every binding (not just for
the special cases) as I thought it would be more thorough if we made sure the
approach works in general, but also there is at least one test for each of the
bindings (just in case some of them might require some particular treatment).
Having exhaustive unit tests allowed me to identify the special cases (such as
quantile, for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
