dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r922141453
##########
r/R/dplyr-funcs.R:
##########
@@ -58,15 +58,27 @@ NULL
#' @keywords internal
#'
register_binding <- function(fun_name, fun, registry = nse_funcs) {
- name <- gsub("^.*?::", "", fun_name)
- namespace <- gsub("::.*$", "", fun_name)
+ qualified_name <- fun_name
+ unqualified_name <- gsub("^.*?::", "", qualified_name)
Review Comment:
the greedy matching with `:+` doesn't seem to be working (I get your point,
I will look into it a bit):
``` r
fun_name <- "somePkg::some_fun"
gsub("^.*?::", "", fun_name)
#> [1] "some_fun"
sub("^.*?:+", "", fun_name)
#> [1] ":some_fun"
```
<sup>Created on 2022-07-15 by the [reprex
package](https://reprex.tidyverse.org) (v2.0.1)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
