nealrichardson commented on code in PR #12826: URL: https://github.com/apache/arrow/pull/12826#discussion_r922101737
########## r/src/compute-exec.cpp: ########## @@ -146,20 +146,12 @@ std::shared_ptr<compute::ExecNode> ExecNode_Scan( options->dataset_schema = dataset->schema(); - // ScanNode needs the filter to do predicate pushdown and skip partitions - options->filter = ValueOrStop(filter->Bind(*dataset->schema())); Review Comment: IIUC the ScanOptions needs the Expression but you have the shared_ptr so it should be this : ``` options->filter = filter.get(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
