westonpace commented on code in PR #13613:
URL: https://github.com/apache/arrow/pull/13613#discussion_r923016526
##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -129,18 +136,19 @@ Result<ExtensionSet> ExtensionSet::Make(
return Status::Invalid("Type ", type_ids[i].uri, "#", type_ids[i].name, "
not found");
}
- set.functions_.reserve(function_ids.size());
+ // set.functions_.reserve(function_ids.size());
for (unsigned int i = 0; i < static_cast<unsigned int>(function_ids.size());
++i) {
if (function_ids[i].empty()) continue;
RETURN_NOT_OK(set.CheckHasUri(function_ids[i].uri));
-
- if (auto rec = registry->GetFunction(function_ids[i])) {
- set.functions_[i] = {rec->id, rec->function_name};
- continue;
- }
- return Status::Invalid("Function ", function_ids[i].uri, "#",
function_ids[i].name,
- " not found");
+ set.functions_[i] = {{function_ids[i].uri, function_ids[i].name}, "dummy"};
+
+ // if (auto rec = registry->GetFunction(function_ids[i])) {
+ // set.functions_[i] = {rec->id, rec->function_name};
+ // continue;
+ // }
+ // return Status::Invalid("Function ", function_ids[i].uri, "#",
function_ids[i].name,
+ // " not found");
Review Comment:
I've uncommented this and merged `FunctionMapping` into
`ExtensionIdRegistry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
