westonpace commented on code in PR #13613: URL: https://github.com/apache/arrow/pull/13613#discussion_r932245697
########## cpp/src/arrow/engine/substrait/serde.h: ########## @@ -111,7 +113,7 @@ ARROW_ENGINE_EXPORT Result<std::vector<compute::Declaration>> DeserializePlans( /// Plan is returned here. /// \return a vector of ExecNode declarations, one for each toplevel relation in the /// Substrait Plan -ARROW_ENGINE_EXPORT Result<compute::ExecPlan> DeserializePlan( +ARROW_ENGINE_EXPORT Result<std::shared_ptr<compute::ExecPlan>> DeserializePlan( Review Comment: I moved the named table provider into the conversion options object being added by @jvanstraten 's PR here: #13537 Hopefully any new options can go into ConversionOptions and that will prevent future creep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
