bkietz commented on a change in pull request #8205:
URL: https://github.com/apache/arrow/pull/8205#discussion_r489743411
##########
File path: cpp/src/arrow/util/atomic_shared_ptr.h
##########
@@ -89,5 +89,25 @@ inline void atomic_store(
*p = r;
}
+template <class T>
+inline bool atomic_compare_exchange_strong(
Review comment:
templates are implicitly `inline`
```suggestion
bool atomic_compare_exchange_strong(
```
##########
File path: cpp/src/arrow/util/atomic_shared_ptr.h
##########
@@ -89,5 +89,25 @@ inline void atomic_store(
*p = r;
}
+template <class T>
Review comment:
Looks correct to me
##########
File path: cpp/src/arrow/type_traits.h
##########
@@ -22,7 +22,7 @@
#include <type_traits>
#include <vector>
-#include "arrow/type_fwd.h"
+#include "arrow/type.h"
Review comment:
this change seems odd; was type_fwd incorrect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
